Make 'isort' consistent about 'build' - #2197
Merged
webknjaz merged 1 commit intoJun 26, 2025
Merged
Conversation
This does not seem to reproduce consistently -- `isort` is executing correctly in pre-commit.ci -- but in some environments and invocations, `isort` is incorrectly reordering imports of `build` because it gets confused by the `piptools.build` module.
sirosen
added
skip-changelog
Member
|
We could also just use ruff for managing imports. See: #1886 |
Member
|
(it's probably best to merge this as a short-term fix anyway) |
webknjaz
approved these changes
Jun 26, 2025
webknjaz
left a comment
webknjaz
left a comment
Member
There was a problem hiding this comment.
I agree that we should slowly adopt ruff.
I'd like to have a separate config, though. But that's a separate thing. I also have some prior art of doing said adoption in stages in Cheroot.
Member
Author
|
I wouldn't mind using Right now the major thing I see in pre-commit that needs attention is the mypy configuration. It doesn't even belong in pre-commit (I have some strong opinions on this one), so fixing that will be a body of work in its own right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not seem to reproduce consistently --
isortis executingcorrectly in pre-commit.ci -- but in some environments and
invocations,
isortis incorrectly reordering imports ofbuildbecause it gets confused by the
piptools.buildmodule.Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.